feat(VCST-4084): saved for later list page #2008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuskithedeveloper
requested review from
Andrew-Orlov,
goldenmaya and
ivan-kalachikov
and removed request for
a team
ivan-kalachikov
previously approved these changes
Oct 20, 2025
Bug: Route Constants ViolationAccording to the PR discussion, line 107 should use "ROUTES.SAVED_FOR_LATER.NAME" instead of the hardcoded string "SavedForLater". The reviewer @ivan-kalachikov specifically pointed this out. This violates the project's convention of using route constants instead of hardcoded strings. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
client-app/shared/wishlists/components/wishlist-products-skeleton.vue
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
client-app/shared/wishlists/components/wishlist-products-skeleton.vue
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ivan-kalachikov
approved these changes
Oct 28, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A separate page for the "Saved for later" list.
"Saved for later" list page under the account section (only available for authorized users):
"See all" button in "Saved for later" cart block:
References
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-4084
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.34.0-pr-2008-bcb0-bcb08c87.zip